Pack static assets into packr box for portability #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
force-pushed
the
bb/hosted-refactor
branch
8 times, most recently
from
b3b6e20
to
b44512e
Compare
rbren
changed the title
rbren
force-pushed
the
bb/hosted-refactor
branch
from
b44512e
to
d29b986
Compare
robscott
approved these changes
Apr 18, 2019
| ) | ||
|
|
||
| // GetAssetBox returns a binary-friendly set of assets packaged from disk | ||
| func GetAssetBox() *packr.Box { |
There was a problem hiding this comment.
Are GetAssetBox() and GetTemplateBox() important for other packages to be able to access?
There was a problem hiding this comment.
GetAssetBox is. GetTemplateBox is debatable, but I might use it in the hosted version rather than just calling MainHandler directly
copy config.yaml to docker image enable external usage of dashboard package gofmt fix comment use packr for assets add gobuffalo/packr dependency add dependencies fix pointer issues add output-file option
rbren
force-pushed
the
bb/hosted-refactor
branch
from
d29b986
to
54a4f92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.